Change {Key: user.xxx, Value: xxx} to {user.xxx: xxx}#17
Open
kuyacarlo wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for the PR! I really like the direction of moving toward XDG support, but I have some concerns about the current implementation. One of the goals of the current architecture is to allow complete isolation of any Git configuration, not just user identity settings. For example, it’s currently possible to do something like: With the approach proposed in this PR, the tool becomes limited to just three settings: user.name, user.email, and user.signingkey. I’d like to preserve the existing flexibility, since it allows users to isolate and manage arbitrary Git configuration values, not only identity-related ones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed the config file to key:value instead of Key: value, Value: value
How about current installs?
Upon update, it would migrate from old configuration to new configuration in place.
Note: after this update, the config won't be backwards compatible.
Possible Fix
Put the new config into the config directly with XDG